Implement Hardcore Mode #5216
Open
Implement Hardcore Mode #5216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtm516
requested changes
Dec 15, 2024
core/src/main/java/org/geysermc/geyser/session/GeyserSession.java
Outdated
Show resolved
Hide resolved
onebeastchris
approved these changes
Feb 6, 2025
Comment on lines
+95
to
+96
| // This is to ensure that you don't get stuck without a respawn screen in hardcore | ||
| if (!entity.isAlive()) { |
There was a problem hiding this comment.
if this is specific to hardcore mode - shouldn't this also check for it?
There was a problem hiding this comment.
This only ever happens if hardcore mode is on afaik, I don't think there is a need for an extra check
I don't think this should be merged for now as on Java if you initially join a world that's not on Hardcore and a proxy sends you to a world that is on Hardcore, this PR doesn't account for that as unfortunately it doesn't seem like it's changable after the StartGamePacket is sent. :/ |
Co-authored-by: rtm516 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR properly translates hardcore mode now that it is available in Bedrock Edition.